Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hang when compression is used but compressed files are not retained #26

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Fix hang when compression is used but compressed files are not retained #26

merged 1 commit into from
Oct 4, 2022

Conversation

knighton
Copy link
Contributor

@knighton knighton commented Oct 4, 2022 •
edited by karan6181
Loading

Fix a bug where we were waiting on an ephemeral downloaded file that another process removes as soon as it decompresses. We should wait on the decompressed form instead, which is retained.

Tracking Issue: CO-1175

karan6181
karan6181 approved these changes Oct 4, 2022
View reviewed changes
Copy link
Collaborator

@karan6181 karan6181 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@knighton knighton merged commit 8441f26 into main Oct 4, 2022
@knighton knighton deleted the james/fix-hang branch October 4, 2022 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karan6181 karan6181 karan6181 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knighton @karan6181